search

curist / grunt-bower

grunt task to copy bower installed packages to other folder(s)
MIT License
93 stars 27 forks source link

grunt-bower failed with newer versions of grunt due to changes in lodash API #59

Closed DaGaMs closed 8 years ago

DaGaMs commented 8 years ago

There were two issues that needed fixing: lodash3 and above only perform certain chained commands when the chain is executed, which requires a call to e.g. value(). Secondly, _.object was deprecated and needs to be aliased to _.zipObject

mattdiamond commented 8 years ago

It should also be noted that grunt.util._ is itself being deprecated.

noppa commented 8 years ago

Found this through this SO question. Nice to see this is being addressed.

Wouldn't it be better in the long run though to just include either lodash or Underscore as a dependency and use that directly instead of balancing between grunt.util. and grunt.utils.? That's what the Grunt team recommends and it might prevent some future incompatibility issues.

DaGaMs commented 8 years ago

Agreed in principle but I was trying to make a low-impact PR here, not change something that could cause a lot of regressions

curist commented 8 years ago

Well, actually I prefer explicitly using lodash, lock dependency version, and no more functionality checks. But as long as tests pass, it's good enough for me. Thanks for addressing this 👍