search

curityio / idsvr-helm

This repository contains the Curity Identity Server helm chart source code.
Apache License 2.0
10 stars 21 forks source link

curity.config.uiEnabled not effective #29

Closed ju-cu closed 2 years ago

ju-cu commented 2 years ago

The default value for curity.config.uiEnabled is false and thus AdminUI and RESTConf interface should be disabled by default. However, the parameter only prevents the admin-port to be added to list of ports in the deployment template. Ports listed there are just informative. See https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/pod-v1/#ports for reference. Port-forwarding will work nevertheless. I expect this parameter to disable the installation of the adminUI, i.e. run unattendinstall --without-admin-ui

anestos commented 2 years ago

I kinda aggree with this @ju-cu , but the rational behind how this works is that when you have the ui disabled, you are adding configuration some other way (i.e with a secret, configMap or by using another image that contains configuration). When that is the case, the unattendedinstall should not even run, so having this extra flag added seemed unnecessary

ju-cu commented 2 years ago

Thanks @anestos for clarifying. The description of the parameter in the chart readme does not indicate that this parameter is supposed to be used together with a configuration that does not include the admin UI. I believe a better name for the parameter would then be curity.config.exposeUiPort or similar that is more self-explanatory for what it does.