search

curityio / idsvr-helm

This repository contains the Curity Identity Server helm chart source code.
Apache License 2.0
10 stars 21 forks source link

Support multiple files in configuration configmap #32

Closed bokristoffersson closed 2 years ago

bokristoffersson commented 2 years ago

Configuration in Curity might be done using many xml-files. By adding a configurationExtraConfigMap that support many items it is possible to configure the server using more than one file. All files specified will be mounted in etc/init folder in the container. In the helm-values.yaml file:

configurationExtraConfigMap: extra-configmap-conf
configurationExtraConfigMapItemNames:

anestos commented 2 years ago

I would prefer to deprecate configurationConfigMapItemName. Until it is removed we can combine whatever is set in that old value with a new one configurationConfigMapItemNames (or configurationCofigMapItemNameArray for example). That way we don't introduce the configurationExtraConfigMap which seems a bit unnecessary imo.

Same change would be welcomed in the configurationSecret

bokristoffersson commented 2 years ago

Thanks for the feedback. This PR is now adding support for mounting several files from both configmaps and secrets. Example:

curity:
  config:
    configuration:
      - configMapRef:
          name: cfg-configmap-name
          items:
            - key: item-1
              path: item-1.xml
            - key: item-2
              path: item-2.xml
      - secretRef:
          name: cfg-secret
          items:
            - key: scrt-1
              path: scrt-1.xml
            - key: scrt-2
              path: scrt-2.xml
      - secretRef:
          name: cfg-secret-2
          items:
            - key: cfg
              path: configuration.xml