search

curl / curl-for-win

Reproducible curl binaries for Linux, macOS and Windows
https://curl.se/windows/
MIT License
686 stars 207 forks source link

Default branch name should be master not main #19

Closed jay closed 3 years ago

jay commented 3 years ago

We use master everywhere in the org but this repo

https://github.com/curl/curl-for-win/settings/branches

vszakats commented 3 years ago

I use main everywhere, and don't plan to change this. Sorry!

jay commented 3 years ago

? Nothing is stopping you from doing that but why did you change it on the organization repo? You know we use master everywhere. I don't see any discussion surrounding this.

vszakats commented 3 years ago

I also haven't found any guidlines that would prohibit changing the default branch name, or specifically prohibit using main. Besides, I've been the only one ever committing here, so I assumed it wouldn't bother anybody. In fact it's rather surprising this is the FIRST EVER feedback I got for curl-for-win from any curl contributor. I've also been preparing for this change for at least 6 months and nobody ever raised it as an issue. I also can't see how this would affect any curl users or even developers. Am I missing something here?

Having said that, I'm glad to pass on maintenance of this repository to anybody interested. First, I'd prefer to stay out of scolding like in this Issue, seconds, I've stopped using these curl builds about two years ago.

So, please let me know if this is a critical issue and if somebody is willing to continue this work with whatever branch name is preferred.

jay commented 3 years ago

My clone failed to fetch, I don't know if this was the cause. I ended up forking and saw you changed it to main. I still don't understand why you did it but ok. I appreciate your work, and you've basically been carrying this so I'll close.

vszakats commented 3 years ago

There is nothing particularly interesting about why I changed it: I never liked "master" that came with Git and find "main" to better describe the purpose and shorter and easier to type. Minor downside is that it may be a little less useful when grepping, but in practice the effect is likely negligible for most projects.

I'm sorry for causing some trouble for you as a result. It is true that sandboxes need to be updated when the default branch is renamed upstream. Here are the steps to do it:

git branch -m master main
git push --set-upstream origin main

Or, just delete the sandbox and git clone again.