search

curl / curl-fuzzer

Quality assurance testing for the curl project
MIT License
82 stars 29 forks source link

scripts/download_openssl: get openssl 3.0.7 #66

Closed bagder closed 1 year ago

bagder commented 1 year ago

Also add "--depth 1" to speed it up

bagder commented 1 year ago

@cmeister2 do we really need enable-fuzz-libfuzzer set in the OpenSSL config? It causes this build failure. I can reproduce on master as well.

bagder commented 1 year ago

I added a commit with that removal to verify that it actually fixes the build.

cmeister2 commented 1 year ago

@cmeister2 do we really need enable-fuzz-libfuzzer set in the OpenSSL config? It causes this build failure. I can reproduce on master as well.

I imagine it was needed for OpenSSL 1.x? https://github.com/google/oss-fuzz/blob/master/projects/openssl/build.sh seems to indicate that it both is still needed and should work...

bagder commented 1 year ago

Doesn't seem to make the CI build happy at least... :disappointed:

cmeister2 commented 1 year ago

Let me take a look...

cmeister2 commented 1 year ago

Have managed to get this building by specifying --with-fuzzer-lib=/usr/lib/llvm-11/lib/clang/11.0.1/lib/linux/libclang_rt.fuzzer-x86_64.a but obviously that's not especially portable.

I think now that ossfuzz CI snippets exist I may spend a bit of time tonight testing whether we can use them to test this repository. If we can then we can rewrite the scripts to use libFuzzingEngine.

cmeister2 commented 1 year ago

https://github.com/curl/curl-fuzzer/actions/runs/3578659913/jobs/6019048050#step:5:779 proves this is working now.

cmeister2 commented 1 year ago

Closes #43