Closed Keitagit-kun closed 6 months ago
Is this using clang, or what compiler is this?
In addition to the compiler and version, what was the CMake command-line?
cmake-3.12.4 + compiler: mingw-w64 x86_64-7.2.0-win32-seh-rt_v5-rev1
cmake command line:cmake command line:
"E:\......\cmake-gui.exe" "C:\Temp\curl-8.7.1-OpenSSL3.1\curl-8.7.1"
cmake build directory:
C:\Temp\curl-8.7.1-OpenSSL3.1\curl-8.7.1\_build
Looks like -pendantic
and/or -Wall
is used. Try to drop them.
This compiler/version is running in CI with no warnings. It also uses -pedantic -Wall
, as part of PICKY_COMPILER=ON
as default: https://ci.appveyor.com/project/curlorg/curl/builds/49500984/job/jxnrun8jm8tsnmbh?fullLog=true
@Keitagit-kun: This looks like the GUI invocation, what would be interesting is the actual cmake.exe
command-line that passes the build options.
That said, you can disable -pedantic -Wall
by passing PICKY_COMPILER=OFF
to cmake.
Update: though we do test this in CI, that build does not include curl_ngtcp2.c
where these warnings appear. Also, this file and curl_osslq.c
are the only two using PRId64
in a format string. Meaning, it's possible these contribute to the issue.
I'd still be useful to see the cmake.exe
invocation to clear out any custom options or C flags.
If I uncheck Picky Compiler
option in cmake-gui, all warnings disappear, but I dont know how/where to get commandline that passed from cmake-gui.exe
to cmake.exe
.
FWIW, I do build curl with mingw-w64 + gcc + ngtcp2, and there are no such warnings there either. gcc is newer though, 13.2.0 12.2.0: https://github.com/curl/curl-for-win/actions/runs/8492022102/job/23264582018
I don't know cmake-gui, but seeing those options might help figuring out what's causing this.
@Keitagit-kun are you able to check if #13231 fixes the warnings for you?
@bagder yes, all warnings fixed, thanks!
I did this
I configure with cmake only)and than compile curl static library (only) with latest nghttp2-1.60/ngtcp2-1.4/nghttp3-1.2 and get many warnings on compilation
[ 95%] Building C object lib/CMakeFiles/libcurl_object.dir/vquic/curl_ngtcp2.c.obj
I expected the following
no warning
curl/libcurl version
curl static lib v8.6 and v8.7.1
operating system
windows