curlpipe / ox

The simple but flexible text editor
GNU General Public License v2.0
3.35k stars 109 forks source link

Get rid of warnings and remove cactus as an installation candidate #140

Closed kurokirasama closed 1 month ago

kurokirasama commented 1 month ago

Describe the bug error when installing

To Reproduce Steps to reproduce the behavior:

cargo install --git https://github.com/curlpipe/ox

gives this error:

error: multiple packages with binaries found: cactus, ox. When installing a git repository, cargo will always search the entire repo for any Cargo.toml.
Please specify a package, e.g. `cargo install --git https://github.com/curlpipe/ox cactus`

and

cargo install --git https://github.com/curlpipe/ox cactus

gives:

Updating git repository `https://github.com/curlpipe/ox`
error: current package believes it's in a workspace when it's not:
current:   /home/kira/.cargo/git/checkouts/ox-4001c41b4fbbd7bf/344262a/kaolinite/examples/cactus/Cargo.toml
workspace: /home/kira/.cargo/git/checkouts/ox-4001c41b4fbbd7bf/344262a/Cargo.toml

this may be fixable by adding `kaolinite/examples/cactus` to the `workspace.members` array of the manifest located at: /home/kira/.cargo/git/checkouts/ox-4001c41b4fbbd7bf/344262a/Cargo.toml
Alternatively, to keep it out of the workspace, add the package to the `workspace.exclude` array, or add an empty `[workspace]` table to the package's manifest

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

curlpipe commented 1 month ago

Does cargo install --git https://github.com/curlpipe/ox ox work?

kurokirasama commented 1 month ago

yes but with these warnings:

Compiling kaolinite v0.9.5 (/home/kira/.cargo/git/checkouts/ox-4001c41b4fbbd7bf/344262a/kaolinite)
warning: unexpected `cfg` condition name: `tarpaulin_include`
  --> kaolinite/src/document.rs:54:15
   |
54 |     #[cfg(not(tarpaulin_include))]
   |               ^^^^^^^^^^^^^^^^^
   |
   = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows`
   = help: consider using a Cargo feature instead
   = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint:
            [lints.rust]
            unexpected_cfgs = { level = "warn", check-cfg = ['cfg(tarpaulin_include)'] }
   = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(tarpaulin_include)");` to the top of the `build.rs`
   = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
   = note: `#[warn(unexpected_cfgs)]` on by default

warning: unexpected `cfg` condition name: `tarpaulin_include`
  --> kaolinite/src/document.rs:81:15
   |
81 |     #[cfg(not(tarpaulin_include))]
   |               ^^^^^^^^^^^^^^^^^
   |
   = help: consider using a Cargo feature instead
   = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint:
            [lints.rust]
            unexpected_cfgs = { level = "warn", check-cfg = ['cfg(tarpaulin_include)'] }
   = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(tarpaulin_include)");` to the top of the `build.rs`
   = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration

warning: `kaolinite` (lib) generated 2 warnings
curlpipe commented 1 month ago

Ah yeah, that... I recently changed around how ox was structured and it seems there are some teething problems

For now, I'll update the readme while I figure out how to dismiss all these warnings and errors

curlpipe commented 1 month ago

Got rid of the warnings in 0.5.3