search

curlysemi / R4Mvc5

R4MVC5 is a Roslyn code generator for ASP.NET MVC5 apps that creates strongly typed helpers that eliminate the use of literal strings in many places
Apache License 2.0
1 stars 0 forks source link

Stropped Action Parameters Generating Incorrect RouteValueDictionary Keys #10

Closed curlysemi closed 5 years ago

curlysemi commented 5 years ago

Example:

        [NonAction]
        public override System.Web.Mvc.ActionResult SomeAction(string param, string @default)
        {
            var callInfo = new T4MVC_System_Web_Mvc_ActionResult(Area, Name, ActionNames.Activate);
            ModelUnbinderHelpers.AddRouteValues(callInfo.RouteValueDictionary, "param", param);
            ModelUnbinderHelpers.AddRouteValues(callInfo.RouteValueDictionary, "@default", @default);
            ActivateOverride(callInfo, param, @default);
            return callInfo;
        }

ModelUnbinderHelpers.AddRouteValues(callInfo.RouteValueDictionary, "@default", @default); should be ModelUnbinderHelpers.AddRouteValues(callInfo.RouteValueDictionary, "default", @default);.

curlysemi commented 5 years ago

Corrected in 1a09e235a58ac2b4a51383a4e9bb5dbc239c8127. (Commit was amended twice to version bump.)