Fix automatic IP address resolving

currys-co-uk / mobile-manager

MobileManager is an application used for automation testing of iOS and Android mobile devices.

GNU General Public License v3.0

8 stars 2 forks source link

Fix automatic IP address resolving #29

Closed CDJojn closed 4 years ago

CDJojn commented 4 years ago

This fix is necessary because of update on MacOs X Catalina - there is strange behavior during automatic resolving of adapter IP address (in case that ListeningIpAddress is not set in managerconfig.json file).

Order of adapters in list are changing and many times were chosen loop-back adapter 127.0.0.1, but this adapter is every time already in use, because MM is listening on 127.0.0.1 by default. In that case starting of MM failed with critical error.

Tested on Win10 and MacOS 10.15.

xfoggi commented 4 years ago

I'm not fully convinced this is the right way to do this ... I might have free time during weekend to have a look if you don't need to merge it right away ;)

xfoggi commented 4 years ago

wow ok, do as you wish

CDJojn commented 4 years ago

@xfoggi This is issue was blocking for us, and this solutions is this same, how is currently written in this resolver. Loopback should'n be there. If you want to try solve this better way I have added this issue - https://github.com/dixons/mobile-manager/issues/30