Bugfix/android screenshots

currys-co-uk / mobile-manager

MobileManager is an application used for automation testing of iOS and Android mobile devices.

GNU General Public License v3.0

8 stars 2 forks source link

Bugfix/android screenshots #34

Closed CDJojn closed 4 years ago

CDJojn commented 4 years ago

Rework of taking screenshot on Android devices. It wasn't working after updating on MacOS Catalina. In new MacOs Catalina was change default shell from Bash to Zsh and that probably caused problem with starting ADB trough Process.Start with UseShellExecute. To avoid similar complications in future I have reworked this on standard process handling without shell background and do it more safe and proper way - take&pull. https://github.com/dixons/mobile-manager/issues/33

CDJojn commented 4 years ago

I'd love to refactor the function RunProcessAndReadOutput. It's a pity that the function returns only stdout and stderr together as a one string.

Sure, but it will be separate issue - these process handling methods are used in whole scope of project it will be bigger refactoring.

Trawais commented 4 years ago

Yeah, definitely.

CDJojn commented 4 years ago

Tested on MacOS Catalina and Windows 10 - OK.