search

cursey / safetyhook

C++23 procedure hooking library.
https://cursey.dev/safetyhook
Boost Software License 1.0
380 stars 48 forks source link

Vcpkg support #69

Open Hary309 opened 6 months ago

Hary309 commented 6 months ago

It would be nice to see this library in the vcpkg registry, I hate having deps as a target inside Visual Studio.

Anyway, this is a great library, thanks for your work!

angelfor3v3r commented 6 months ago

It would be nice to see this library in the vcpkg registry, I hate having deps as a target inside Visual Studio.

Anyway, this is a great library, thanks for your work!

I'm not sure if any of the current maintainers use Vcpkg but I'm sure someone could create a portfile for the library and we wouldn't be against it. My question is though, what's wrong with using the Amalgamated builds? They won't add a target and just live on your include path/in your primary project.

Hary309 commented 6 months ago

what's wrong with using the Amalgamated builds? They won't add a target and just live on your include path/in your primary project.

It is even worse to keep the deps sources as part of your primary project 😛 So I would rather move it to a separate target.

angelfor3v3r commented 6 months ago

what's wrong with using the Amalgamated builds? They won't add a target and just live on your include path/in your primary project.

It is even worse to keep the deps sources as part of your primary project 😛 So I would rather move it to a separate target.

I don't think it's that bad, they're very small files and it keeps it simple, but I understand your concerns and I don't see anything wrong with getting a portfile made for the library. If you have experience with Vcpkg perhaps you could get a simple portfile working to get the ball rolling? 😄

Hary309 commented 6 months ago

If you have experience with Vcpkg perhaps you could get a simple portfile working to get the ball rolling? 😄

I don't have any experience with portfiles but this is a good opportunity to learn it finally, I will see what I can do.