cursive-team / connections

Cursive Connections
https://connections.cursive.team
3 stars 0 forks source link

Fixing Tessa's Account #71

Closed stevenelleman closed 2 weeks ago

stevenelleman commented 2 weeks ago

I'm going to put all context of the issue here as a thread.

stevenelleman commented 2 weeks ago
image
stevenelleman commented 2 weeks ago

https://github.com/cursive-team/connections/blob/main/apps/frontend/src/lib/storage/localStorage/user/connection/tap.ts#L29

if (
    !tap.ownerUsername ||
    !tap.ownerDisplayName ||
    !tap.ownerSignaturePublicKey ||
    !tap.ownerEncryptionPublicKey ||
    !tap.ownerPsiPublicKeyLink
  ) {
    throw new Error("Tap owner username, display name, or keys not found");
  }
stevenelleman commented 2 weeks ago

So one or more of these are missing. If I had to guess, I bet it would be a user input (UserName or DisplayName) which is optional.

stevenelleman commented 2 weeks ago

Bingo, display name (corresponding to User Name) is missing.


{
    "chipIssuer": "EDGE_CITY_LANNA",
    "chipIsRegistered": true,
    "tap": {
        "chipPublicKey": "...",
        "message": "...",
        "signature": "...",
        "tapCount": 16,
        "ownerUsername": "Tessla",
        "ownerDisplayName": "", [*** empty value ***] 
        "ownerBio": "๐Ÿค๐Ÿ’Ž๐Ÿงก",
        "ownerSignaturePublicKey": "...",
        "ownerEncryptionPublicKey": "...",
        "ownerPsiPublicKeyLink": "...",
        "ownerUserData": {
            "telegram": {
                "username": "Hi_tessla"
            }
        },
        "timestamp": "2024-10-13T03:28:38.430Z"
    }
}```
stevenelleman commented 2 weeks ago

Here's where the Display Name is set: https://github.com/cursive-team/connections/blob/main/apps/frontend/src/features/register/EnterUserInfo.tsx#L45

stevenelleman commented 2 weeks ago

Options: