search

curso-r / treesnip

Parsnip backends for `tree`, `lightGBM` and `Catboost`
https://curso-r.github.io/treesnip
GNU General Public License v3.0
86 stars 13 forks source link

dials objects #20

Open topepo opened 4 years ago

topepo commented 4 years ago

You convert mtry to a proportion. You might consider changing: 

parsnip::set_model_arg(
  model = "boost_tree",
  eng = "catboost",
  parsnip = "mtry",
  original = "rsm",
  func = list(pkg = "dials", fun = "mtry"),
  has_submodel = FALSE
)

to 

parsnip::set_model_arg(
  model = "boost_tree",
  eng = "catboost",
  parsnip = "mtry",
  original = "rsm",
  func = list(pkg = "dials", fun = "mtry_prop"),
  has_submodel = FALSE
)

once I I transfer it over to dials from rules where it currently resides.

There are a lot of parameters to this engine (and for lightGBM). If you make a list of the ones that other might tune, we can add dials parameters to make their optimization easier.

siegfried commented 3 years ago

I just noted that num_leaves is missing, which is important according to LightGBM's docs. Should it be added to dials? Or parsnip?