search

curso-r / treesnip

Parsnip backends for `tree`, `lightGBM` and `Catboost`
https://curso-r.github.io/treesnip
GNU General Public License v3.0
85 stars 13 forks source link

Fixing up R CMD Check #35

Closed tonyk7440 closed 3 years ago

tonyk7440 commented 3 years ago

Following up on https://github.com/curso-r/treesnip/pull/34 to try to get this to build successfully but have hit a bit of a roadblock.

  1. Error from logs 
    E  Running 'testthat.R' [70s] (1m 9.8s)
Running the tests in 'tests/testthat.R' failed.
Complete output:
 > library(testthat)
 > library(treesnip)
 Loading required package: parsnip
 > test_check("treesnip")

    which doesn't tell me much.

I then tried running devtools::test() next but my R session crashes each time.

image

I'm not sure if this is a 'my machine' issue, does this happen for others?

  1. Other than that, I've updated an arg to use sample_prop instead of sample_size so that an error doesn't get generated. I think sample_size should be substituted for sample_prop in general to avoid confusion, does anyone have an opinion on this?