search

curso-r / treesnip

Parsnip backends for `tree`, `lightGBM` and `Catboost`
https://curso-r.github.io/treesnip
GNU General Public License v3.0
85 stars 13 forks source link

Remove catboost #46

Closed topepo closed 2 years ago

topepo commented 2 years ago

Related to #45

It would be good for someone to make a release or branch before merging this so that we can recycle the previous work if they get catboost on CRAN

dfalbel commented 2 years ago

I am up for submitting treesnip to CRAN by removing catboost. Currently we are observing a crash on windows when lightgbm is loaded together with parsnip though (see https://github.com/microsoft/LightGBM/issues/4464) . I think we should probably get that fixed before releasing treesnip.

eitsupi commented 2 years ago

microsoft/LightGBM#4464 seems to have been resolved. Any update?

dfalbel commented 2 years ago

Hi @eitsupi

Yes, planning to work on this soon. LightGBM itroduced a few breaking changes in the newer version that we should fix before releasing (see #50).

Let us know if you are interested in working in this issue.

dfalbel commented 2 years ago

Thanks @topepo ! Favoured #55 instead