search

curso-r / treesnip

Parsnip backends for `tree`, `lightGBM` and `Catboost`
https://curso-r.github.io/treesnip
GNU General Public License v3.0
86 stars 13 forks source link

parsnip::set_model_arg should be "sample_size" not "sample_prop" #52

Open p-schaefer opened 2 years ago

p-schaefer commented 2 years ago

Here: https://github.com/curso-r/treesnip/blob/60aade546d340f0c88325506881b7aa4a54f4d33/R/lightgbm.R#L169

and this: https://github.com/curso-r/treesnip/blob/60aade546d340f0c88325506881b7aa4a54f4d33/R/lightgbm.R#L171 should be: func = list(pkg = "dials", fun = "sample_prop"),