curso-r / treesnip

Parsnip backends for `tree`, `lightGBM` and `Catboost`
https://curso-r.github.io/treesnip
GNU General Public License v3.0
85 stars 13 forks source link

remove feature_pre_filter from lgb.Dataset #53

Closed amazongodman closed 2 years ago

amazongodman commented 2 years ago

I suggest removing the cause of the error. A warning from the lightGBM package, which may stop as an error in the future.

dfalbel commented 2 years ago

Thanks, we have fixed this in a slightly different way in https://github.com/curso-r/treesnip/commit/2a38bea9260187dc69c2cb2452f6ca4ea150d96d#diff-b9735225cbf8a61e6611dc7bfddd8c8b859bcdfd4359f68f089e0ae68117be4dR275