search

cursorless-dev / cursorless

Don't let the cursor slow you down
https://www.cursorless.org/
MIT License
1.15k stars 81 forks source link

Fix reading settings for VSCode Insiders #1807

Open pokey opened 1 year ago

pokey commented 1 year ago

In case anyone else is using VS Code Insiders on a Mac, you will get this error as well, as src/apps/vscode_settings.py does not check for the Insiders settings which are at Code - Insiders/User/settings.json instead of Code/User/settings.json

Not sure if anything should be done about it officially, as Insiders is beta for a reason, but good to know that it's an easy manual fix.

Originally posted by @nathanheffley in https://github.com/cursorless-dev/cursorless/issues/543#issuecomment-1682397422

nathanheffley commented 1 year ago

On my main computer I didn't encounter this issue because I had also installed regular VS code and configured cursorless for it, and now that I think about it, I didn't have to edit any settings when I switched to Insiders. I imagine supporting separate settings would be difficult, and in my experience I liked not configuring it again but I would have been pretty confused if I had tried to change the settings in Insiders and nothing happened.

auscompgeek commented 1 year ago

If we do fix this there's no reason to not do it on all OSes.

I imagine most using both will sync settings between the two. Question then is, how often do people only use insiders, or don't sync settings?

pokey commented 1 year ago

If we do fix this there's no reason to not do it on all OSes.

Ah didn't realise this was broken on other OSes as well

I imagine most using both will sync settings between the two. Question then is, how often do people only use insiders, or don't sync settings?

Yeah unfortunately there's no winning here until we have talon rpc 😕