Closed jaresty closed 1 week ago
I think I responded to all your comments. I wasn't sure if I should remove the define split commands. Everything seems to be working at the moment.
We probably gonna deprecate define in favor of follow. No sense adding another define then.
I'll remove the define changes then, when I have some time. If you want to make changes here before I get to it please feel free (I'm away for the week)
I removed the define command. Only the follow command remains.
I think I addressed all the comments. Anything I missed?
Thanks for cleaning it up! @pokey
Nice exactly what I wanted! :)
Nice exactly what I wanted! :)
I didn't actually read any of your comments, so it's a good sign that we independently arrived at the same conclusion 😄
Nice exactly what I wanted! :)
I didn't actually read any of your comments, so it's a good sign that we independently arrived at the same conclusion 😄
Heh don't know if I should be hurt or impressed by that :D
well they had all been marked as resolved so I assumed they'd already been addressed 😅
Oops, sorry. I was using them kind of like a todo list-should I have left them open? Appreciate all the guidance-thanks for helping me get this done 😀
Oops, sorry. I was using them kind of like a todo list-should I have left them open? Appreciate all the guidance-thanks for helping me get this done 😀
That's ok. If you're confident you've resolved them, feel free to mark them resolved. If you have any doubt, though, best to leave them open and let us have a look to see if they've been resolved
This pull request adds a command to split the window and follow in one command.
Checklist