cursorless-dev / cursorless

Don't let the cursor slow you down
https://www.cursorless.org/
MIT License
1.09k stars 77 forks source link

Split define action #2392

Closed jaresty closed 1 week ago

jaresty commented 1 month ago

This pull request adds a command to split the window and follow in one command.

Checklist

jaresty commented 1 month ago

I think I responded to all your comments. I wasn't sure if I should remove the define split commands. Everything seems to be working at the moment.

AndreasArvidsson commented 3 weeks ago

We probably gonna deprecate define in favor of follow. No sense adding another define then.

jaresty commented 3 weeks ago

I'll remove the define changes then, when I have some time. If you want to make changes here before I get to it please feel free (I'm away for the week)

jaresty commented 3 weeks ago

I removed the define command. Only the follow command remains.

jaresty commented 1 week ago

I think I addressed all the comments. Anything I missed?

jaresty commented 1 week ago

Thanks for cleaning it up! @pokey

AndreasArvidsson commented 1 week ago

Nice exactly what I wanted! :)

pokey commented 1 week ago

Nice exactly what I wanted! :)

I didn't actually read any of your comments, so it's a good sign that we independently arrived at the same conclusion 😄

AndreasArvidsson commented 1 week ago

Nice exactly what I wanted! :)

I didn't actually read any of your comments, so it's a good sign that we independently arrived at the same conclusion 😄

Heh don't know if I should be hurt or impressed by that :D

pokey commented 1 week ago

well they had all been marked as resolved so I assumed they'd already been addressed 😅

jaresty commented 1 week ago

Oops, sorry. I was using them kind of like a todo list-should I have left them open? Appreciate all the guidance-thanks for helping me get this done 😀

pokey commented 1 week ago

Oops, sorry. I was using them kind of like a todo list-should I have left them open? Appreciate all the guidance-thanks for helping me get this done 😀

That's ok. If you're confident you've resolved them, feel free to mark them resolved. If you have any doubt, though, best to leave them open and let us have a look to see if they've been resolved