search

cursorless-dev / vscode-parse-tree

Syntax trees for VSCode using tree-sitter
MIT License
41 stars 35 forks source link

Upcoming change to tree-sitter-clojure #58

Closed sogaiu closed 1 year ago

sogaiu commented 1 year ago

I'm opening this issue to let the maintainers know that we're planning to merge a change to the tree-sitter-clojure master branch that might affect this repository.

The change is here: sogaiu/tree-sitter-clojure#31

A brief overview of the changes follows.

kwd_lit and sym_lit will now contain up to 3 new nodes:

(kwd_lit
  ns: (kwd_ns)
  delimiter: "/"
  name: (kwd_name))

(sym_lit
  ns: (sym_ns)
  delimiter: "/"
  name: (sym_name))

Only the (kwd_name) and (sym_name) are required.

sym_lit nodes can still contain metadata nodes (this is unchanged).

We looked at the package.json and yarn.lock files in this repository but didn't quite determine exactly which commit or version was being depended on. So just in case...

If you are not prepared to use these changes, please consider using the commit at tag v0.0.9 or the corresponding tagged release. (Those should be functionally equivalent to the current master branch (8c23e0ec07 as of this writing).)

If the changes do cause issues, please tell us.

Our current plan is to merge around 2023-01-05 which is in about 2 weeks time.

On a more general note...

Though at this time we don't anticipate many changes going forward, we're planning to post certain change-related announcements to a pinned issue ahead of merging such changes.

Please have a look at the issue and consider subscribing :)

pokey commented 1 year ago

thanks for the heads up! we pin all our versions, because most tree-sitter grammar maintainers are not as diligent as you 😄. See https://github.com/tree-sitter/tree-sitter/discussions/1768 for an interesting relevant discussion if you've not already seen it