search

cursorless-dev / vscode-parse-tree

Syntax trees for VSCode using tree-sitter
MIT License
40 stars 35 forks source link

Add preliminary xaml support using html parser #59

Closed fatalerrorx closed 1 year ago

pokey commented 1 year ago

I'm not sure this PR or https://github.com/cursorless-dev/cursorless/pull/1229 are necessary. When I open a .xaml file, VSCode automatically treats it as xml. I do run into https://github.com/cursorless-dev/vscode-parse-tree/issues/49#issuecomment-1253042360 pretty quickly, but that's independent. Is VSCode treating .xaml files as something other than xml for you?

fatalerrorx commented 1 year ago

Unfortunately for me it doesn't work. Saying take tag or take value gives me the error "Cannot read properties of undefined (reading 'apply')". I also can't use things like take inside.

pokey commented 1 year ago

@fatalerrorx yes that's likely due to https://github.com/cursorless-dev/vscode-parse-tree/issues/49#issuecomment-1247538465. Xaml tends to use longer tag names, and for whatever reason our html parser barfs on those https://github.com/tree-sitter/tree-sitter-html/issues/30 / https://github.com/cursorless-dev/vscode-parse-tree/issues/49

fatalerrorx commented 1 year ago

@pokey Yes I realized that after I made the comment.