curtiscde / hugo-theme-massively

Massively theme for Hugo static site generator
https://hugo-theme-massively.netlify.app
Other
155 stars 138 forks source link

Enhancement: Utilize Hugo's disqus template #38

Closed shortword closed 6 years ago

shortword commented 6 years ago

In the same vein as issue 37, I noticed that Hugo provides an internal disqus template which, if we aligned with it, would make maintenance life easier in the long run.

However, using this template diverges a bit from the previous behavior of the package. Previously, disqus would only show up in massively if the front matter included a 'disqusid'. This differs from how Hugo handles it internally, as well as other packages I've used for Jekyll and Wordpress, which all show it on every post/blog page unless otherwise turned off. If nothing else I'd push for alignment with Hugo as being the driving factor for this proposed change.

As with my other filed issue, I've created a branch in my fork and will submit a pull request for review. Please let me know if you have any questions or concerns.

Mike

shortword commented 6 years ago

See pull request: https://github.com/curttimson/hugo-theme-massively/pull/39

curtiscde commented 6 years ago

39 has now been merged to master