search

curtiscde / hugo-theme-massively

Massively theme for Hugo static site generator
https://hugo-theme-massively.netlify.app
Other
155 stars 138 forks source link

Add asset handling using Hugo Pipes #80

Closed seshaljain closed 4 years ago

seshaljain commented 4 years ago

Fixes #35

Added a hugo pipes workflow to concatenate and minify css and js assets Required moving assets to assets/ directory

!Requires Hugo 0.43+ Extended

seshaljain commented 4 years ago

Also, using Hugo Pipes natively eliminates adding external Gulp workflows

seshaljain commented 4 years ago

Looks like Netlify still uses non-Extended versions of hugo, so the build would fail on netlify

Checking the resources/ folder is a temporary workaround netlify/binrc#17 netlify/build-image#182

seshaljain commented 4 years ago

On further investigation: 🕵️ Netlify Blog: A more flexible build architecture with updated Linux

@curtistimson This will require a modification via the control panel on Netlify

curtiscde commented 4 years ago

Apologies I'm late replying to this - thanks for the contribution!

Following your last commit, do you still think this will require changes in the Netlify control panel? It looks as though the build is passing successfully:

https://deploy-preview-80--hugo-theme-massively.netlify.com

seshaljain commented 4 years ago

No, committing the resources allows Hugo to prevent from building source files at build. So, it should work on a standard Netlify setup.

Netlify is working towards allowing Hugo extended versions, so resources folder won't be required then.

curtiscde commented 4 years ago

Apologies for the delay @seshaljain.

I've approved / merged your changes, and finally been able to close #35 😄

Thanks again for the contribution!