Include perpetrator in message deletion and fix broken optional bot logging

curtisf / logger

Loggerbot version 3, the Discord bot serving nearly 24 million users.

https://logger.bot

GNU General Public License v3.0

374 stars 131 forks source link

Include perpetrator in message deletion and fix broken optional bot logging #35

Closed SkySwimmer closed 2 years ago

SkySwimmer commented 2 years ago

Fixed a small issue in the messageCreate event handler checking for bot instead of system, this broke the 'logbots' option. Also made it that messageDelete includes the perpetrator in the footer when possible.

SkySwimmer commented 2 years ago

Just noticed the typo, sorry

SUPERCHIEFYT commented 2 years ago

This most likely won't go through for a few different reasons.

Perpetrator for messageDeletes in the main bot will never be a thing (mostly due to rate limits, and it's a patreon feature)

Also it would be much preferred to have a discussion in the support server before making prs

curtisf commented 2 years ago

Yes, perpetrator for the main bot won't be included on messageDelete from ratelimits mainly (Logger sees a firehose of message deletes). The patron bot has it because it is small and doesn't pose a ratelimit issue. However, Logger being open source does allow for the possibility to add it to your own instance for free. This PR shows a possible way to implement it individually 👍

SkySwimmer commented 2 years ago

Ah got it