Suggestion: Consider applying TF best practices to written Terraform

curtismu7 / Master-Flow

PingOne Master flow for PingOne Authentication and MFA

2 stars 4 forks source link

Suggestion: Consider applying TF best practices to written Terraform #10

Open patrickcping opened 7 months ago

patrickcping commented 7 months ago

👋

Great repo!

The Ping Terraform best practices guides have now been released, which have useful suggestions to mitigate against breaking changes on the provider as well as DaVinci/PingOne specific considerations. The suggestion is to review and apply the best practices to the Terraform in the repo when convenient. Feedback welcome on the docs repo here!

https://terraform.pingidentity.com/best-practices/

kylemoorehead-pingidentity commented 7 months ago

This is great, @patrickcping! I was definitely doing some kind weird things before, and I am really excited to migrate this over to the 3.0 and apply best practices!

I'll drop a note here when we get this work complete and provide any feedback as I go.

Thanks for all your hard work!