search

curtisullerich / attendance

An attendance application built for the Iowa State University Cyclone Football 'Varsity' Marching Band.
MIT License
6 stars 2 forks source link

Can't update user information #221

Closed curtisullerich closed 11 years ago

curtisullerich commented 11 years ago

Possibly caused by #220

curtisullerich commented 11 years ago

This seems to work if a director updates a student's information, but not if a director or student updates his or her /own/ information.

danstiner commented 11 years ago

Probably an activation or caching issue. Also should look at eliminating the double store operation on user updates before and after updating grades, seems silly.

curtisullerich commented 11 years ago

The call to ValidationUtil.isUniqueSecondaryEmail somehow blows away changes to the user. I really don't understand how.

danstiner commented 11 years ago

Should be fixed by 4c0a7a1d15e8198e060fc999a5b08d702b9a685d

curtisullerich commented 11 years ago

I tried writing a test case for this, but I couldn't repro in a JUnit. I really need to read more about the datastore.

danstiner commented 11 years ago

Should be possible, not worth the time given its fixed and will hopefully the code will never be changed enough again to cause issues.