curtisullerich / attendance

An attendance application built for the Iowa State University Cyclone Football 'Varsity' Marching Band.
MIT License
6 stars 2 forks source link

Can't approve absences as a director #236

Open danstiner opened 11 years ago

danstiner commented 11 years ago

Severity: high From: Dan Stiner (stiner) Url: /director/viewabsence?absenceid=5275456790069248 User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/28.0.1500.95 Safari/537.36 On mobile site: false

Message: Form Field Values: {"forms":[{"id":"form1","fields":{"date":"08/19/2013","time":"","Event":"08/19/2013 at 11:50 PM","absenceid":"5275456790069248","eventid":"5118776383111168","SubmitChanges":"Submit"}},{"id":"form2","fields":{"delete":"Delete Absence"}}]}

Error Messages: [Invalid Input: The input DateTime is invalid.] Can't mark an absence as approved without entering a check-in/out time, which isn't actually relevant for an absence.

danstiner commented 11 years ago

Fix will be to make check-in/out time hidden and not required when the type is an absence.

curtisullerich commented 11 years ago

This is a feature that I don't think was ever used. The fix shouldn't take more than an hour, though, so I want it done, but it's low priority.

curtisullerich commented 11 years ago

225 will fix this.