search

curtisullerich / attendance

An attendance application built for the Iowa State University Cyclone Football 'Varsity' Marching Band.
MIT License
6 stars 2 forks source link

Tests fail in Eclipse but not Maven #253

Closed curtisullerich closed 10 years ago

curtisullerich commented 10 years ago

This is due to naming conventions. Maven only runs classes as tests if they start or end with Test. ServletAccess is an example.

curtisullerich commented 10 years ago

@danstiner Did this test ever pass? I don't know that /classlist has ever been a valid path. It returns 404 and the mock ends up will a null pointer exception. It's also not asserting anything. So it was just verifying no assumptions were thrown?

https://github.com/curtisullerich/attendance/blob/868061f71dbd92af15695537a77ce13d6941817f/src/test/java/edu/iastate/music/marching/attendance/test/servlets/ServletAccessTest.java#L76

danstiner commented 10 years ago

By the way, please do fixes like this on master, preferably as a separate branch even, rather than committing straight to the feature branch webappv2-rewrite