Viability - Githubissues

curtiswilkinson / roomservice

https://www.npmjs.com/package/roomservice

MIT License

6 stars 1 forks source link

Viability #1

Open curtiswilkinson opened 6 years ago

curtiswilkinson commented 6 years ago

[x] before and after life cycle hook
[x] implement run & run sync options for configuration
[ ] allow a --debug flag to disable friendly output
[x] review non-deterministic nature of init unit test
[x] configure the maximum stdout buffer size for the run child processes
[x] review the building spinner and update with services to be built
[x] formatting of error messages in the friendly output
[x] readme
[x] review of configuration template for the init command
[x] release onto npm and scripts around the release/publish process

curtiswilkinson commented 6 years ago

Maybe a better service life cycle system would be :

run: fully async and is initiated first but not awaited
beforeRunSync: all members of this are run synchronously, but this hook must complete before continuing on
runSync: these are all run synchronously, and all must finished before continuing on
afterRunSync: these are run asynchronously after the sync commands are finished