search

curusarn / resh

RESH ❯❯ Contextual shell history for zsh and bash
MIT License
1.01k stars 19 forks source link

Investigate deduplication in resh-cli #103

Closed curusarn closed 4 years ago

curusarn commented 4 years ago

What happens when there are two history entries with identical pwd and command line BUT with a different exit code?

I'm suspecting that if the record with an error (non-zero exit code) comes first it could shadow the record without an exit code. This would penalize the record even though there are instances where it has run successfully.

curusarn commented 4 years ago

My gut feeling was right - fixed in: https://github.com/curusarn/resh/commit/14611c87c915e155e5c42d2a573564e5c55028a6