search

curveball / a12n-server

An open source lightweight OAuth2 server
Apache License 2.0
448 stars 49 forks source link

Features/logo #358

Closed ikbensiep closed 2 years ago

ikbensiep commented 2 years ago

Adds a logo to the /login page. Logo is a link in the server_settings table, or if absent there, the Curveball logo (hardcoded to curveballjs.org).

The PR is still incomplete, I think the logo should be added to all pages, but up for suggestions. I tried to looking into that but I'm not sure how to add the prop to the main layout.hbs template, @evert do you have some suggestions ?

Also note how the parameter is typed in formats/html.ts, not sure if that\s the best way to do it, the other option was to have await getSetting('logo_url') || '' in the controller, which seems ugly.

pschwyter commented 2 years ago

Can you also include some screenshots so we can see what's changed?

pschwyter commented 2 years ago

Oh and also update the README to mention this feature? Probably just a section in the getting-started.md file?

ikbensiep commented 2 years ago

@evert @pschwyter I updated the getting started doc.
This is not my expertise; perhaps it should be moved and/or have a paragraph added? Please review, cheers!

pschwyter commented 2 years ago

woohoo thanks for the documentation!

evert commented 2 years ago

Just needs the new logo and the new browser package and this is good to go.