search

curveball / a12n-server

An open source lightweight OAuth2 server
Apache License 2.0
453 stars 49 forks source link

When editing an OAuth2 client, the checkboxes for client grants are not checked #420

Closed mhum closed 2 years ago

mhum commented 2 years ago

If I have an existing OAuth2 client with allowed grant types saved: image

Those checkboxes aren't checked when I edit the client: image

I have to re-check them or else it saves the form and updates the client with no allowed grant types which is very confusing.

syedfkabir commented 2 years ago

This issue was closed due two changes: https://github.com/badgateway/ketting/pull/451 https://github.com/curveball/browser/pull/146

I tested the issue @mhum was having after these PRs, and the issue is resolved.

evert commented 2 years ago

Was there a PR that updates these dependencies?

syedfkabir commented 2 years ago

Was there a PR that updates these dependencies?

From what I understand, ketting got updated, so the browser needed a dependency update is that correct?

syedfkabir commented 2 years ago

I was still testing my local browser changes against the media-api, I finally got it reverted and I see the issue is not resolved. One more step to go.

evert commented 2 years ago

Makes sense!

evert commented 2 years ago

This was fixed after merging #426