curveball / core

The Curveball framework is a TypeScript framework for node.js with support for modern HTTP features.
https://curveballjs.org/
MIT License
525 stars 7 forks source link

upgraded @types/node version and quickly corrected test namespace/emi… #135

Closed c-strong closed 4 years ago

c-strong commented 4 years ago

…t import and usage

evert commented 4 years ago

Not upgrading to @types/node at version 13 is was on purpose. We're actually on version 10 of that package, because we want to support node 10 and not use any APIs that were introduced later.

In addition, we've had a lot of breaking builds in the past by using the unstable versions of these packages. The unstable @types/node package tends to undergo a lot of changes.

evert commented 4 years ago

The 'import' line is now fixed on master, but we're staying on @types/node@10. This change should fix running the server with @types/node@13 though!

Thank you for this, without this ticket it would have been hard for me to discover the issue.