curvednebula / apibake-js

Convert OpenAPI to PDF.
https://curvednebula.com/apibake
21 stars 2 forks source link

Add option to disable page numbers #4

Closed 0x0dr1y closed 5 months ago

0x0dr1y commented 5 months ago

Hey,

it would be great if there is an option to disable the page number generation. Looking at the code this should be quite simple.

What are your thoughts on this?

curvednebula commented 5 months ago

Yes, I think this should be easy to do. I'll check. I'm curious why is it important to hide page numbers?

0x0dr1y commented 5 months ago

Yes, I think this should be easy to do. I'll check. I'm curious why is it important to hide page numbers?

Cool, thanks! Let me know if you need any help.

Use case: The resulting pdf is getting merged with other independent pdfs in the end. After merging the site numbers are programatically added, thus disabling page numbers is important as they're simply inaccurate in such cases.

curvednebula commented 5 months ago

@MrDeerly Please check the latest version. Now you can specify the following option to disable page numbers: --footer ""

0x0dr1y commented 5 months ago

@curvednebula Thanks alot for your fast efforts! I can confirm the new version works as intended. Again, thanks for the great project :+1:

curvednebula commented 5 months ago

Thanks!