curvefi / curve-frontend

MIT License
18 stars 17 forks source link

Combine all APYs into a single value #142

Open bout3fiddy opened 4 months ago

bout3fiddy commented 4 months ago

A suggestion from a prolific user was to combine all APYs into a single number, such that a user simply needs to do a hover over the number to get a full breakdown of the yield sources.

An example from Balancer:

Image

This also allows us to reduce the number of columns by 1.

The fe should then show a min and max value, with a breakdown of of the min being base + unboosted incentives, and max being base + boosted incentives.

amytsang commented 4 months ago

Image To do this ticket:

  1. We need to switch Lend APY to Lend APR or switch Rewards APR to Rewards APY (Probably Rewards need to be switched to APY)?
  2. Combine different assets into 1. Also asset type will disappear unless hover.

End result will look like something like this: Table cell header: Total APR | APY Table row content: <min-percent> - <max-percent> <Tooltip>

Tooltip: Lend APR|APY: <number>% CRV: <number>% CRV Incentives: <number>% <token>

Please address these two comments and once ready, we can move this ticket to unblock

bout3fiddy commented 4 months ago

tagging @michwill to weigh in here.

bout3fiddy commented 4 months ago

Discussed and:

  1. switch to APR, and on hover you can show apr|apy for lend.
  2. also fine.

proposed tooltip looks fine:

Lend APR (APY): <number>% (<number>%)
CRV APR: <number>% CRV
Incentives APR: <number>% <token>
michwill commented 4 months ago

I think yes, we switch to APR here

michwill commented 4 months ago

We need to switch Lend APY to Lend APR or switch Rewards APR to Rewards APY (Probably Rewards need to be switched to APY)?

Let's do APR

Combine different assets into 1. Also asset type will disappear unless hover.

That's fine on desktop view. On mobile view, since there's no hover, can probably do line 12% (7% lend + 5% CRV)