curvefi / curve-frontend

MIT License
20 stars 22 forks source link

Change health to either always use the parameter `full=True` or always use `full=False` #180

Open saint-rat opened 4 months ago

saint-rat commented 4 months ago

On the main lend/crvUSD UI when it calculates health it seems to call the health view method with full=True when the health is green (oracle price is >3 bands higher), and full=False when health is yellow (oracle price is <=3 bands higher). Is this the desired behavior? Just seems confusing for the user that their health evaporates for seemingly no reason.

Eg. for wstETH market with active band -65 and oracle price 4,391.15 1 wstETH collateral, 3660 debt: 7.71% health (green) - bands -61 to -52 1 wstETH collateral, 3670 debt: 7.42% health (green) - bands -61 to -52 1 wstETH collateral, 3680 debt: 4.23% health (yellow) - bands -62 to -53 (by my calcs I think it should be around ~7% with full=True)

I personally think it would be clearer to always call with full=True or full=False (with full=True as my preference). Changing the full parameter without telling the user why seems a bit misleading to me.

What's everyone else think?