curvenote / editor

An interactive scientific editor built with ProseMirror, React and Redux - by Curvenote.
https://curvenote.com
MIT License
291 stars 32 forks source link

Link validation #136

Closed rowanc1 closed 2 years ago

rowanc1 commented 2 years ago

Currently our URLs are too restrictive. This should likely stop with a regexp approach and use a new URL() and look at the throw instead.

For example, doesn't like local hosts with ports, or curve.space. :(

image

discussion & requirements: https://curvenote.com/@curvenote/architecture/links-in-editor

stevejpurves commented 2 years ago

possibly related: https://github.com/curvenote/editor/issues/139 & https://github.com/curvenote/editor/issues/137

rowanc1 commented 2 years ago

Fixed in #142.