curvenote / prosemirror-docx

Export a prosemirror document to a Microsoft Word file, using docx.
MIT License
97 stars 13 forks source link

Fix dependencies vs. devDependencies #33

Closed joshkel closed 1 month ago

joshkel commented 1 month ago

@changesets/cli is only used for development and the build and release process; putting it under dependencies means that anything using prosemirror-docx gets many unneeded packages installed.

rowanc1 commented 1 month ago

It is likely that the lock file needs to be updated for this as well!

joshkel commented 1 month ago

@rowanc1 , moving a package from dependencies to devDependencies doesn't affect what packages are installed, so the lockfile doesn't necessarily update.

If I run yarn, it does make a change:

diff --git i/yarn.lock w/yarn.lock
index e4707ba..48f5398 100644
--- i/yarn.lock
+++ w/yarn.lock
@@ -4541,7 +4541,7 @@ jsx-ast-utils@^3.3.1:
     array-includes "^3.1.5"
     object.assign "^4.1.2"

-jszip@^3.1.5:
+jszip@^3.10.1:
   version "3.10.1"
   resolved "https://registry.yarnpkg.com/jszip/-/jszip-3.10.1.tgz#34aee70eb18ea1faec2f589208a157d1feb091c2"
   integrity sha512-xXDvecyTpGLrqFrvkrUSoxxfJI5AH7U8zxxtVclpsUtMCq4JQ290LY8AW5c7Ggnr/Y/oK+bQMbqK2qmtk3pN4g==
@@ -4966,7 +4966,6 @@ nanoid@^3.1.30:
   resolved "https://registry.yarnpkg.com/nanoid/-/nanoid-3.1.30.tgz#63f93cc548d2a113dc5dfbc63bfa09e2b9b64362"
   integrity sha512-zJpuPDwOv8D2zq2WRoMe1HsfZthVewpel9CAvTfc/2mBD1uUT/agc5f7GHGWXlYkFvi1mVxe4IjvP2HNrop7nQ==

-
 nanoid@^5.0.4:
   version "5.0.7"
   resolved "https://registry.yarnpkg.com/nanoid/-/nanoid-5.0.7.tgz#6452e8c5a816861fd9d2b898399f7e5fd6944cc6"

However, I see these changes whether or not I change package.json, which suggests to me that the main branch ended up with its package.json and yarn.lock slightly out of sync. (Or, perhaps, the lockfile contents ended up being platform-dependent; this is with Yarn 1.22.22, Node 18.20.2, macOS.) Fixing that seemed out of scope for this PR.

rowanc1 commented 1 month ago

Roger that, I am used to NMP package locks. Thank you for following up!