Closed chanhosuh closed 1 year ago
Numpy no longer allows the "Y" unit in its timedelta constructor, e.g. timedelta64(1, 'Y'), due to a "year" being an ambiguous number of nanoseconds.
timedelta
timedelta64(1, 'Y')
We fix this by using timedelta64(365, 'D'), which does not materially impact our annualization calculation.
timedelta64(365, 'D')
Fixes #233.
The coverage rate went from 74.93% to 74.93% :arrow_down: The branch rate is 61%.
74.93%
61%
100% of new lines are covered.
100%
Description
Numpy no longer allows the "Y" unit in its
timedelta
constructor, e.g.timedelta64(1, 'Y')
, due to a "year" being an ambiguous number of nanoseconds.We fix this by using
timedelta64(365, 'D')
, which does not materially impact our annualization calculation.Fixes #233.
Hygiene checklist
Changelog entryEverything public has a Numpy-style docstring(modules, public functions, classes, and public methods)Cute Animal Picture