Cryptoswap `bonding_curve`

curveresearch / curvesim

Simulates Curve Finance pools

MIT License

156 stars 32 forks source link

Cryptoswap `bonding_curve` #272

Closed allt0ld closed 1 year ago

allt0ld commented 1 year ago

Description

Updated curvesim.bonding_curve to output bonding curves for Cryptoswap pools.

Closes #148.

Hygiene checklist

[x] Changelog entry
[x] Everything public has a Numpy-style docstring (modules, public functions, classes, and public methods)
[x] Commit history is cleaned-up with minor changes squashed together and descriptive commit messages following Tim Pope's style

Cute Animal Picture

github-actions[bot] commented 1 year ago

Coverage report

The coverage rate went from 75.75% to 75.84% :arrow_up: The branch rate is 62%.

85.45% of new lines are covered.

Diff Coverage details (click to unfold)

### curvesim/tools/bonding_curve.py `85.45%` of new lines are covered (`69.23%` of the complete file). Missing lines: `89`, `119`, `123`, `161`, `167`, `169`, `172`, `173`

allt0ld commented 1 year ago

Waiting to hear if adding STABLESWAP = Union[CurvePool, CurveMetaPool, CurveRaiPool] and CRYPTOSWAP = Union[CurveCryptoPool] to the curvesim.pool module, for type hinting and type checking, is a good idea before merging.