curzel-it / pipper

App that allows users to keep a webview always visible on their screen, on top of other windows, like for watching youtube while working and stuff. Still a proof of concept
MIT License
89 stars 6 forks source link

About dialog window should be not behind pipper #11

Closed muescha closed 11 months ago

muescha commented 11 months ago

the about dialog window should be not behind pipper

Bildschirmfoto 2023-11-23 um 00 48 06

curzel-it commented 11 months ago

Hi @muescha, thanks for all the feedback you shared today! The "floating" effect is controlled by the NSWindow.level property, I need to check if there is an avaiable value there that allows to stay over other apps but below dialogs. If there is on, happy to add it, if there isn't one I am afraid this will be very challenging to solve. I should be able to check this during the weekend, I'll get back to you soon ๐Ÿ‘

muescha commented 11 months ago

If it would behind all dialogs it would be nice.

The dialog I mentioned is the about dialog from pipper, which I expect to be above the pipper app.

curzel-it commented 11 months ago

So... I tried all available levels, and couldn't find one that works "good enough". If this is blocking a specific use-case of yours, it might be worth for you to give it a shot, it's a single line of code:

self?.level = shouldHover ? .floating : .normal

Just relpace floating with any other available value.

Instead, if you've reported this as a possible improvement / cosmetic issue, thanks again, I really appreaciate it, but I don't think there's a valid solution that does not break other workflows :/

muescha commented 11 months ago

The positioning of Pipper's about dialog above Pipper seems purely cosmetic to meโ€”an issue primarily related to appearance. I noticed that the settings dialog appears above Pipper and remains visible, whereas Pipper's about dialog appears behind Pipper.

To maintain consistency, perhaps displaying the about content within Pipper itself instead of introducing an additional about dialog could be a solution.

curzel-it commented 11 months ago

I noticed that the settings dialog appears above Pipper and remains visible, whereas Pipper's about dialog appears behind Pipper.

Yes, this makes sense because this specific "about dialog" is something created and managed by macos, so it's a different process, the settings page is attached to the same window and therefore attaches properly.

To maintain consistency, perhaps displaying the about content within Pipper itself instead of introducing an additional about dialog could be a solution.

Exactly. I have some plans for the menu bar, when I get to that I'll just replace the default dialog with something else ๐Ÿ‘