While creating bookmarks: icon path is not updated

curzel-it / pipper

App that allows users to keep a webview always visible on their screen, on top of other windows, like for watching youtube while working and stuff. Still a proof of concept

MIT License

86 stars 6 forks source link

While creating bookmarks: icon path is not updated #13

Open muescha opened 10 months ago

muescha commented 10 months ago

where:

in Create Bookmark dialog

what I do:

i type a url
i delete some chars

what I see:

typing new chars are visible and the favicon file name is added
deleted chars are not resulting in changes in the file icon path
until i reach the previous url then new chars are added to the icon path

what i expect:

all changes should be visible in the icon path (also delete chars)
only after i manualy change the icon path, then further changes to url should not pushed to the icon path

muescha commented 10 months ago

pipper-bookmark

curzel-it commented 9 months ago

@muescha Makes perfect sense, will fix!

curzel-it commented 9 months ago

Just pushed, let me know if it works better!

muescha commented 9 months ago

a little bit better: I can delete values. But you should track if the icon value is changed "by hand".

Because it is saved, but when I reopen the edit dialog it shows for a second the new path, but after some millisecods it changes to \(domain)/favicon.ico.

pipper-bookmark2

the icon path is from the head tag:

<link rel="icon" href="./system/images/template/favicon.png" type="image/x-icon">

https://www.aktionspreis.de/system/images/template/favicon.png

curzel-it commented 9 months ago

Because it is saved, but when I reopen the edit dialog it shows for a second the new path, but after some millisecods it changes to (domain)/favicon.ico.

D'oh... Dumb mistake... I fixed this, but the rest of the behaviour is the same (changing the url overrides the icon).

You're right in what you mentioned in the other issue, I should just analyze the url and check for a favicon in meta/head/etc.

There's also another possibility, which is to simply let Google do it for us, like so:

https://s2.googleusercontent.com/s2/favicons?domain=www.stackoverflow.com

I'll think about it for a couple of days, I'll probably end up with:

Use icon from Google by default and show the preview in the bookmark editor view
Add a checkbox called "Use custom icon"
When "Use custom icon" is enabled, the "icon" field appears and gg