search

cushon / issues-import

0 stars 0 forks source link

Review: bugpatterns for injecting final fields #151

Open cushon opened 10 years ago

cushon commented 10 years ago

Original issue created by sgoldfeder@google.com on 2013-06-24 at 08:54 PM

Link to code review: https://github.com/sgoldfed/error-prone/pull/9

Purpose of code changes:

new bugpatterns for injecting final fields.

If you use javax.inject.Inject, an error is given in compliance with the JSR-330 spec that forbids using javax.inject.Inject on final fields. If you use com.google.inject.Inject, a warning is given in compliance with the Guice documentation that allows this, but reccomends not to do it.

cushon commented 10 years ago

Original comment posted by cgruber@google.com on 2013-06-24 at 09:35 PM

(No comment entered for this change.)

Status: Accepted Owner: cgruber@google.com