Add check for non-static nested class

cushon commented 9 years ago

Original issue created by alexloh@google.com on 2013-08-13 at 03:44 AM

According to good programming practice, nested classes should be made static because:

Non-static inner classes consume additional memory per instance of enclosing class
Enclosing instance cannot be gc-ed
Strong indication to programmer that nested class is logically independent

This check finds eligible non-static nested classes that do not reference a member or type variable of their enclosing class, and applies a fix to add the 'static' modifier to the nested class. The nested class must be enclosed in either a top-level class or a static class.

cushon commented 9 years ago

Original comment posted by alexloh@google.com on 2013-08-13 at 06:11 PM

https://codereview.appspot.com/12814044

cushon commented 9 years ago

Original comment posted by alexloh@google.com on 2013-08-20 at 03:23 AM

This is filed in Rietveld under issue 13117043 (https://codereview.appspot.com/13117043/)

cushon commented 9 years ago

Original comment posted by eaftan@google.com on 2013-08-28 at 06:19 PM

Code review is done. Will merge with head once Alex sends a link to his repo.

Status: Started Owner: eaftan@google.com

cushon commented 9 years ago

Original comment posted by eaftan@google.com on 2013-09-03 at 09:50 PM

Merged into head.

Status: Fixed CC: alexloh80

cushon / issues-import

Add check for non-static nested class #172