search

cushon / issues-import

0 stars 0 forks source link

Code review request: fixed NPE in Matchers.methodReturns(), added Supplier.VOID_TYPE #181

Closed cushon closed 9 years ago

cushon commented 9 years ago

Original issue created by rburny@google.com on 2013-09-09 at 11:49 PM

Link to code review: codereview.appspot.com/13298046/

Purpose of code changes: 1) Fix Null Pointer Exception that methodReturns() throws when matching against constructor. This didn't manifest before, because such check was always hidden by other matchers. For example, CovariantEquals was first checking method name (but if checks were reordered, NPE would be thrown). 2) Add Supplier.VOID_TYPE: I'll need it for methodReturns(VOID_TYPE) as part of JUnit3TestNotRun (this could also be added to JUnit4TestNotRun)

cushon commented 9 years ago

Original comment posted by eaftan@google.com on 2013-09-12 at 05:44 PM

(No comment entered for this change.)

Status: Done Owner: eaftan@google.com