search

cushon / issues-import

0 stars 0 forks source link

Annotation Matchers don't respect inheritance #185

Open cushon opened 9 years ago

cushon commented 9 years ago

Original issue created by rburny@google.com on 2013-09-11 at 10:33 PM

Annotations Matcher doesn't respect inherited annotations (i.e. when type annotation is marked with @Inherited, and class doesn't overwrite it, it should be inherited from superclass. It is not inherited from interfaces and only applicable to type annotations).

cushon commented 9 years ago

Original comment posted by eaftan@google.com on 2013-09-12 at 12:13 AM

(No comment entered for this change.)

Status: Accepted Owner: eaftan@google.com

cushon commented 9 years ago

Original comment posted by eaftan@google.com on 2013-09-12 at 12:14 AM

Be sure to look both on annotations() and hasAnnotation(), they seem to repeat some logic and both suffer from the issue.

cushon commented 9 years ago

Original comment posted by radoslaw.burny on 2013-11-22 at 04:22 PM

I'm working on that, though I don't think it can be solved completely. Please see discussion at https://codereview.appspot.com/30940043/.