search

cushon / issues-import

0 stars 0 forks source link

Mac OS X: IntelliJ 12 runs with Apple JRE 1.6 (the only one officially supported) but the IntelliJ plugin seems to be compiled using Java7 #189

Closed cushon closed 9 years ago

cushon commented 9 years ago

Original issue created by jens.nehlmeier on 2013-09-12 at 03:16 PM

What steps will reproduce the problem?

Install IntelliJ plugin on Mac OS and restart IntelliJ. You can have Java 6,7,8 installed, IntelliJ 12 will always pick Apple JRE 1.6 to run itself. You can force IntelliJ to select Java 7 but its not officially supported by JetBrains (and thus not the default).

What is the expected output? What do you see instead?

com.intellij.compiler.CompilerConfigurationImpl@23d7c3d2: com/google/errorprone/intellij/ErrorProneIdeaCompiler : Unsupported major.minor version 51.0 [Plugin: Error-prone plugin] com.intellij.diagnostic.PluginException: com/google/errorprone/intellij/ErrorProneIdeaCompiler : Unsupported major.minor version 51.0 [Plugin: Error-prone plugin] at com.intellij.ide.plugins.cl.PluginClassLoader.d(PluginClassLoader.java:108) at com.intellij.ide.plugins.cl.PluginClassLoader.loadClass(PluginClassLoader.java:63) at java.lang.ClassLoader.loadClass(ClassLoader.java:247) at java.lang.Class.forName0(Native Method) at java.lang.Class.forName(Class.java:249) at com.intellij.openapi.extensions.impl.ExtensionComponentAdapter.loadClass(ExtensionComponentAdapter.java:148)

Would be nice if you could also provide a Java 6 compiled IntelliJ plugin for Mac OS users.

cushon commented 9 years ago

Original comment posted by eaftan@google.com on 2013-09-12 at 05:05 PM

Alex, aren't you developing using IntelliJ on a Mac? Can you take a look?

Owner: alexeagle@google.com CC: eaftan@google.com

cushon commented 9 years ago

Original comment posted by alexeagle@google.com on 2013-09-12 at 06:26 PM

Yes, looks like my fault. I need to re-build the plugin on the official 1.0 tag anyway so the checks sync up with the command line javac. I'll make sure -target=1.6 this time.

Status: Accepted

cushon commented 9 years ago

Original comment posted by alexeagle@google.com on 2013-11-20 at 08:22 PM

Re-built the plugin using IDEA's Build -> Prepare plugin module for deployment.

Confirmed the version: $ javap -verbose ~/Desktop/com/google/errorprone/ErrorProneScanner.class | grep version: minor version: 0 major version: 50

I just submitted the plugin to the jetbrains plugin repository; it should appear soon. Marking this fixed since the version issue should be resolved. Follow issue 210 for remaining steps to get the plugin working for all IJ users.

Status: Fixed