search

cushon / issues-import

0 stars 0 forks source link

Code review for mdempsky/classpath #198

Open cushon opened 9 years ago

cushon commented 9 years ago

Original issue created by mdempsky@google.com on 2013-09-30 at 04:01 AM

Link to code review: https://github.com/cushon/issues-import/commit/106999e009c1ab474a060936dd58bc5c8f2fe73b

Purpose of code changes: It bothered me that javac's able to compile code without tools.jar being on the user class path, but when ErrorProneCompiler compiles code the user class path does include error-prone (and tools.jar). So I decided to investigate why and fix it.

cushon commented 9 years ago

Original comment posted by eaftan@google.com on 2013-10-02 at 03:43 AM

This LGTM, but Alex has more context on the tools.jar stuff, so I'd appreciate it if he could take a look.

Status: Accepted Owner: alexeagle@google.com