cushon / issues-import

0 stars 0 forks source link

Full Java 8 support #246

Open cushon opened 9 years ago

cushon commented 9 years ago

Original issue created by eaftan@google.com on 2014-03-27 at 04:19 PM


Right now we have a build for javac 8 but are missing two important items needed for full support:

1) Our Jenkins continuous build does not run Java 8 yet, only 6 and 7.

2) We don't yet distribute the error-prone 8 jars to Sonatype. We probably want to distribute two sets of jars, one for versions 6 and 7, and one for 8. It would be nice if Maven could figure out which dependency to use based on the version of javac installed.

cushon commented 9 years ago

Original comment posted by t.broyer on 2014-03-27 at 05:16 PM


Apparently, the error_prone module does change behavior depending on what's in the classpath (if the javac8 jar is there, I suspect the class construction to fail, falling back to javac7), so how about shading everything in a single jar? If I made a wrong assumption, then how about making it true, loading the appropriate class depending on the current JVM version?

cushon commented 9 years ago

Original comment posted by t.broyer on 2014-03-27 at 05:17 PM


Apparently, the error_prone module doesn't change behavior depending on what's in the classpath (if the javac8 jar is there, I suspect the class construction to fail, falling back to javac7), so how about shading everything in a single jar? If I made a wrong assumption, then how about making it true, loading the appropriate class depending on the current JVM version?

cushon commented 9 years ago

Original comment posted by eaftan@google.com on 2014-04-07 at 10:07 PM


Issue #240 has been merged into this issue.

cushon commented 9 years ago

Original comment posted by eaftan@google.com on 2014-04-07 at 10:12 PM


Alex has added the Java 8 continuous build, so we need to investigate the Maven integration. Thanks Thomas for the pointer, we'll take a look.


Labels: Priority-High

cushon commented 9 years ago

Original comment posted by michael.j.bailey@aexp.com on 2014-07-30 at 05:54 PM


This maybe related to this Errorprone Gradle issue: https://github.com/tbroyer/gradle-errorprone-plugin/issues/5

cushon commented 9 years ago

Original comment posted by YogurtEarl on 2014-07-30 at 05:55 PM


It may be related to this Gradle Errorprone issue: https://github.com/tbroyer/gradle-errorprone-plugin/issues/5

cushon commented 9 years ago

Original comment posted by YogurtEarl on 2014-07-30 at 09:04 PM


Any ETA? :)

cushon commented 9 years ago

Original comment posted by eaftan@google.com on 2014-08-22 at 05:44 PM


Issue #251 has been merged into this issue.