search

cuspaceflight / bamboo

Cooling system modelling for liquid rocket engines.
GNU Affero General Public License v3.0
16 stars 4 forks source link

Poor performance with pressure drop #12

Closed hf360F closed 3 years ago

hf360F commented 3 years ago

There is some computation that could be avoided by unifying the friction factor and pressure drop methods, but I'm not convinced this is entirely the problem, both functions are analytical / simple.

hf360F commented 3 years ago

Problem is poor performance with coolprop generally, not directly related to pressure drop functions Best fix for now is switching back to thermo, as implemented since this was opened